mart added a comment.
In D19392#421881 <https://phabricator.kde.org/D19392#421881>, @davidedmundson wrote: > > so, we colorize monochrome icons treating them as just masks, and that works ok, tough there isn't any spec to know with 100% certainty if an icon is monochrome or colored (all icon names that end up with -symbolys usually are monochrome, but in breeze and other themes monochrome icons are all over the place and often it depends from the icon size) > > For breeze there's an alternate approach. We "just" add "-symbolic" symlinks in everywhere. We could even use this code to automate doing that. That would cover the android case. not really, one would still have to use the -symbolic name instead of the real one for every icon.. and only in android, which wouldn't be cross platform, so no. > > >> Or technically one can do a kirigami app with zero dependencies and not have qqc2-desktop-style installed and run it on gnome. > > It seems gnome themes also do the -symbolic suffix thing and do SVG replacement like we do. With very similar keys too! > Even ignoring this Kirigami issue we have an issue of Breeze icons on gnome and vice versa that's worth fixing. > > If we need to do this as a temporary measure, then fine. > > However, I want to hear a plan on what a "correct" cross-desktop KF6 + Qt6 solution would be - and maybe start some ML threads together before accepting. > Otherwise we'll carry on with hacks that only half work forever and ever. this tough is about doing something about it in KIconLoader which is completely ortogonal to this patch. we can either support both coloring methods or agree on only one (which as usual, would be porting everything to the gnome method) wouldn't be that hard.. providing iff the gnome method works with QtSvg which is not a given. the problem remain that: I can't always use KiconLoader in Kirigami, as well as accessing to the icons svg files at all. Changing how breeze does coloring doesn't solve the problem this patch adresses. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19392 To: mart, #kirigami Cc: cfeck, davidedmundson, plasma-devel, domson, dkardarakos, apol, mart, hein
