leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision.
REVISION SUMMARY I got a difficult-to-reproduce crash, which pointed at the fact that this error can, at times, be null. Without the validity check this patch introduces, we then attempted to deref that null pointer, and crashed. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19561 AFFECTED FILES libdiscover/backends/FwupdBackend/FwupdBackend.cpp To: leinir, #discover_software_store, apol, ngraham Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
