leinir marked 4 inline comments as done. leinir added inline comments. INLINE COMMENTS
> apol wrote in KNSBackend.cpp:151 > we can just compare with == here, it will be easier to read. Tru dat... i was just keeping consistency with the long list below, but yeah, at the very least for now we've just got the one source, and can always add a check like this if we find we have more app sources later on :) > apol wrote in KNSBackend.cpp:159 > I wonder if that's alright, it's very ad-hoc to the opendesktop semantics, > isn't it? This is pretty much just mapping the current machine's abilities to run certain types of binaries to what is offered by opendesktop, yes. I am quite unsure as to how to implement this in some other way. In particular, we need to be able to make sure that on x86_64 we get both x86 and x86_64 packages, so we can't just send along the result verbatim and ask opendesktop to return what Qt returns (given we have to produce a mapping anyway)... > apol wrote in KNSBackend.cpp:186 > decoration isn't used anymore, it could make sense to not include it at all > over here. Good idea :) This is just code moved down a bit, but i'll just pop that in here as well while we're at it :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19837 To: leinir, apol, ngraham, #discover_software_store Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
