ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  The spacing change is clearly correct. As for the width change, we should 
match the exact calculation used for the other combobox we're trying to match, 
which is `width: theme.mSize(theme.defaultFont).width * 24`. Otherwise they'll 
drift out of sync when `formAlignment` changes or the next time 
`Kirigami.Units.largeSpacing` is modified.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to