apol added a comment.

  +1 for documenting and the text.
  
  Decorating with some URLs to pam documentation would be nice.

INLINE COMMENTS

> README.txt:3
> +
> +During the pam "auth" (pam_authenticate) stage the module gets the password 
> in plaintext
> +It hashes it against a random salt previously generated by kwallet of random 
> data and keeps it in memory

`plain<space>text`

> README.txt:9
> +
> +KWalletd recieves the pre-hashed key and then sits there doing nothing. 
> (before the QApp constructor)
> +

QApp -> QApplication

> README.txt:13
> +
> +Kwalletd receives this, sets the env and continues into the normal bootup.
> +

kwalletd

Also what's "the env"?

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D20081

To: davidedmundson, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

Reply via email to