filipf added a comment.

  Good fix, the lack of implicitHeight was leading to confusion before if there 
are even any wallpapers present.
  
  One question though: wouldn't it be better to define the height in 
`units.gridUnit` instead of raw pixels, or even absolutely by doubling the 
height of one grid item? From my understanding, when scaling is changed the 
grid items are also resized so the window won't open showing 2 rows of 
wallpapers anymore, as was desired.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

To: tigrang, davidedmundson
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to