romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.
Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are
copy-paste from the Wayland backend. It would make sense to have a new abstract
parent class such that the code is shared.
INLINE COMMENTS
> xlibbackend.h:74
> QStringList listMouses(const QStringList &blacklist) override;
> + QVector<QObject*> getDevices() const override { return m_device ?
> QVector<QObject*> { m_device.data()} : QVector<QObject*>(); }
>
Put the definition in the cpp file.
> touchpadconfiglibinput.cpp:55
>
> - m_backend = TouchpadBackend::implementation();
> + m_backend = backend;
> m_initError = !m_backend->errorString().isNull();
Put it in the constructor initializer list.
> touchpadbackend.h:43
>
> + TouchpadInputBackendMode m_mode;
> +
Such a member varialbe shouldn't be public.
> touchpadbackend.h:51
> + virtual bool getDefaultConfig() { return false; }
> + virtual bool isChangedConfig() const { return false; }
>
Unnecessary changes. Revert these pls to keep the diff size in check.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D20186
To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
