cfeck added a comment.

  Are the `toLower()` calls really needed? I would have expected that 
`localeAwareCompare()` is case insensitive by default.
  
  Also, please use `return x` instead of `return (x)`.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D20386

To: jen6, #plasma, cfeck, pino, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to