davidedmundson added a comment.

  I'd like us to get in the habbit of putting new designs of theme changes on 
the store before we change defaults.

INLINE COMMENTS

> OsdItem.qml:31
>  
> -    PlasmaCore.IconItem {
> -        id: icon
> -
> -        height: parent.height - Math.max(progressBar.height, label.height)
> -                              - ((units.smallSpacing/2) * 3) //it's an svg
> -        width: parent.width
> +    width: Math.max(Math.min(Screen.desktopAvailableWidth / 2, 
> implicitWidth), units.gridUnit * 15)
> +    height: units.iconSizes.medium

Screen.desktopAvailableWidth is all screens. Do you mean that?

---

Dialog should understand Layout attached properties of mainItem, so you can 
write the slightly more semantic:

Layout.max screen.width/2
Layout.min: units * 15

Though it's Dialog, so who knows....

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: broulik, #plasma, #vdg
Cc: davidedmundson, hein, Codezela, Fuchs, filipf, zzag, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to