mart added inline comments. INLINE COMMENTS
> jobsmodel.cpp:72 > +{ > + static QWeakPointer<JobsModel> s_instance; > + if (!s_instance) { any reason to go this way instead of Q_GLOBAL_STATIC ? I guess you want to have cases in which none of it is ever created? tough the case would be when there are no notification plasmoids, but in that case the plugin containing the library wouldn't be loaded? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20265 To: broulik, #plasma Cc: mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol