fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> options.js:174
> +                            // When the extension is reloaded, any call to 
> extension APIs throws, make sure we show at least some form of error
> +                            saveMessage.innerText = "Saving settings failed 
> (" + e + ")";
> +                        }

This should show `error` as well

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D20819

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to