johngehrig added a comment.
The API for `errorString()` calls out that it should not be called when `error() == 0`. The code does not explicitly check for this scenario. Somehow users (myself and others) can get into a state where `!rc && error() == 0`, and we are calling `errorString()` anyways. What's the harm in adding a line of defensive code so that we conform to the API? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D20859 To: johngehrig, ngraham, davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
