romangg added a comment.
In D20186#465361 <https://phabricator.kde.org/D20186#465361>, @ngraham wrote: > @atulbi This has caused a failure in the CI: > > https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console > > 09:12:41 /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal error: libinput-properties.h: No such file or directory > 09:12:41 #include <libinput-properties.h> > 09:12:41 ^~~~~~~~~~~~~~~~~~~~~~~ > 09:12:41 compilation terminated. > > > Looks like we need to make the libinput xorg dev package a mandatory dep (boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I know it's short notice but we branch in two days; do you think you could fix this? Thanks! Of course we miss out again on these compilation corner cases... For that see D21220 <https://phabricator.kde.org/D21220>. I found a grave issue now when testing though: Saved values are not restored on Reboot. Are they saved at all to a config file? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart