On Wednesday, 15 May 2019 15:55:01 CEST Friedrich W. H. Kossebau wrote:
> Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil:
> > Thus I'd kindly ask you to take one more look at the codebase [1] and let
> > me know if there are any more issues to fix, or if we can proceed to
> > include this in the next Plasma release.
>
> Pushed some small fixes to toplevel CMakeLists.txt
>
> Other things seen on quick look at code (also not tested runtime):
> * kded misses a Messages.sh file.
> * no COPYRIGHT license files in the repo
> * kde_enable_exceptions() duplicated a few times, perhaps only do in subdirs
> where needed or use of kde_target_enable_exceptions() if fitting
> * libkbolt being a private library could be reflected in the libname, also
> get install(TARGETS kbolt ${KDE_INSTALL_TARGETS_DEFAULT_ARGS} LIBRARY
> NAMELINK_SKIP)All fixed, thanks for the review (and the fixes)! Dan > > Cheers > Friedrich -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683
signature.asc
Description: This is a digitally signed message part.
