ngraham added inline comments.

INLINE COMMENTS

> keyboard_config.cpp:112
> +        QList<LayoutUnit> x11layouts = X11Helper::getLayoutsList();
> +        for(const LayoutUnit& layoutUnit : x11layouts) {
> +            layouts.append(layoutUnit);

Style: space between `for` and `(`

> keyboard_config.cpp:116
> +    } else {
> +        for(const QString& layoutString : layoutStrings) {
> +            layouts.append(LayoutUnit(layoutString));

Ditto

REVISION DETAIL
  https://phabricator.kde.org/D21497

To: McPain, ngraham, broulik, hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to