mthw added a comment.
In D21639#475864 <https://phabricator.kde.org/D21639#475864>, @ngraham wrote: > Ah, this change only affects those horrible scrollbars that disappear when not being used and leave you unable to see at a glance what position you're at in the view or even that the view is scrollable in the first place. This change seems to work fine and improves the UI for that particular use case, so +1. > > However Phab doesn't expose that this patch has significant formatting issues. It looks like your editor changed all the line endings for `src/gtk320/widgets/_scrollbar.scss`, which is an undesired change that must be reverted. There's also a hidden whitespace issue with the change in `src/gtk318/widgets/_scrollbar.scss`. It helps to do a final `git diff` before submitting the patch, which can help catch issues like this. > > Please fix those issues, then we can land this. Have you read my comment twice above, about this look? https://imgur.com/a/2EeF7pp Wouldn't it be better? Shoud I post it here? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
