fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > startplasma-wayland.cpp:41 > + // set XKB_DEFAULT_{MODEL,LAYOUT,VARIANT,OPTIONS} accordingly. > + if > (QDBusConnection::systemBus().interface()->isServiceRegistered(QStringLiteral("org.freedesktop.locale1"))) > { > + auto queryAndSet = [](const QByteArray &var, const QByteArray & > value) { AFAICT this won't work as expected: localed is only launched on demand, which `isServiceRegistered` does not care about. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21725 To: apol, #plasma, fvogt Cc: fvogt, davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart