sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision.
REVISION SUMMARY it was the only remaining user of that dialog helper. the connection between the two was fairly meh. the engine would invoke the kded module over dbus, the module would then process the request, find that only one desktop entry is specified, resulting in one action being found and then running that action on behalf of the engine. this is overly complicated for no additional gain. the engine is the sole user of this functionality AND it already had knowledge of the service system, so soliduiserver in this case doesn't actually add anything. it's just a more involved call chain. the useful code of soliduiserver is now in the hotplug dataengine directly and the soliduiserver no longer supports the actions dialog. hotplug is now the sole authority for hotplugging. soliduiserver: - include cleanup - all classes no longer in use have been removed - kdelibs4support is no longer a link target - new link targets i18n + widgetsaddons (previously pulled in by kdelibs4support) hotplug: - hotplugjob now directly executes service actions using classes imported from soliduiserver - no longer links qtdbus - new translation domain plasma_engine_hotplug (for i18n call in imported service classes) - new link against ki18n for that reason TEST PLAN running an action works same as before, internally it no longer relies on dbus/kded REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21761 AFFECTED FILES dataengines/hotplug/CMakeLists.txt dataengines/hotplug/Messages.sh dataengines/hotplug/deviceaction.cpp dataengines/hotplug/deviceaction.h dataengines/hotplug/deviceserviceaction.cpp dataengines/hotplug/deviceserviceaction.h dataengines/hotplug/hotplugjob.cpp soliduiserver/CMakeLists.txt soliduiserver/deviceaction.cpp soliduiserver/deviceaction.h soliduiserver/deviceactionsdialog.cpp soliduiserver/deviceactionsdialog.h soliduiserver/deviceactionsdialogview.ui soliduiserver/devicenothingaction.cpp soliduiserver/devicenothingaction.h soliduiserver/deviceserviceaction.cpp soliduiserver/deviceserviceaction.h soliduiserver/soliduiserver.cpp soliduiserver/soliduiserver.h To: sitter, broulik Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart