sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision.
REVISION SUMMARY kde4_add_app_icon is fairly deprecated. additionally the call itself was madness because it actually pulls the icon out of oxygen in the install location. that is assuming the icon theme is even installed at build time (which is probably always not true in our binary factorization environments). lastly the app_icon helper is only useful to pick up icons for osx and windows, neither are target platforms for plasma. remove the app_icon call entirely until a use for it arises, which should be... never... unless we decide that we want to replace explorer.exe ;) REPOSITORY R120 Plasma Workspace BRANCH noappicon REVISION DETAIL https://phabricator.kde.org/D21766 AFFECTED FILES klipper/CMakeLists.txt To: sitter Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart