broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I originally didn't consider this neccessary because we have a 
`qMessageHandler`, so every `qDebug` goes through the proper formatting. 
However, if an external application is launched, it might blatantly print to 
stdout.

TEST PLAN
  - Triggered Purpose menu from a website, chose "send via email" which 
triggered Thunderbird and then quit Thunderbird. Previously the host was killed 
by printing
  
    *** UTM:SVC TimerManager:registerTimer called after profile-before-change 
notification. Ignoring timer registration for id: telemetry_modules_ping
  
  on stdout. Now the host continues to run smoothly. Everything else is 
unaffected

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21934

AFFECTED FILES
  host/connection.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Reply via email to