ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This patch doesn't seem to make the back and forward buttons lose their 
arrows once I've applied D19311 <https://phabricator.kde.org/D19311>, and it 
also makes all KDE apps crash like so:
  
    (gdb) bt
    #0  QObject::property (this=0x0, 
        name=0x7fffe0ab28d0 <Breeze::PropertyNames::toolButtonNoMenuArrow> 
"_kde_toolButton_noMenuArrow") at kernel/qobject.cpp:3961
    #1  0x00007fffe0a8cd3f in BreezePrivate::hasInlineIndicator (
        toolButtonOption=0x555555c2e9e0, toolButton=<optimized out>)
        at /home/dev/kde/src/breeze/kstyle/breezestyle.cpp:160
    #2  0x00007fffe0a8df30 in Breeze::Style::toolButtonSizeFromContents (
        this=<optimized out>, option=<optimized out>, contentsSize=..., 
        widget=<optimized out>) at 
/home/dev/kde/src/breeze/kstyle/breezestyle.cpp:2739

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Reply via email to