fvogt added inline comments. INLINE COMMENTS
> kdeconnectplugin.cpp:188 > > QStringLiteral("org.kde.kdeconnect.device.share"), > - > QStringLiteral("shareUrl")); > - msg.setArguments({url}); > + !text.isEmpty() > ? QStringLiteral("shareText") : QStringLiteral("shareUrl")); > + if (!text.isEmpty()) { This looks like an ugly hack. Is there any reason not to add a new `shareText` event? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21987 To: broulik, #plasma, fvogt, davidedmundson, nicolasfella Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart