davidedmundson added inline comments. INLINE COMMENTS
> sddmauthhelper.cpp:76 > + QStringList sourceDirEntries = sourceDirectory.entryList > (QDir::AllDirs); > + QDir > destination(QStringLiteral("/var/lib/sddm/.config/fontconfig/")); > + Don't hardcode /var/lib/sddm KUser("sddm").homeDir() would be better > sddmauthhelper.cpp:118 > + //QDir cacheDir(QStringLiteral("/var/lib/sddm/.cache/")); > + if (!args[QStringLiteral("sddmUserConfig")].isNull()) { > + fontconfigDir.removeRecursively(); What's the point of this argument when you hardcode/evaluate it so much in this file. > advanceconfig.cpp:40 > > -AdvanceConfig::AdvanceConfig(const KSharedConfigPtr &config, QWidget > *parent) : > +AdvanceConfig::AdvanceConfig(const KSharedConfigPtr &config, KCModule > *parent) : > QWidget(parent), we ended up not needing to access KCModule from this class REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D22191 To: filipf, #plasma, ngraham, davidedmundson, #vdg Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart