GB_2 added inline comments.

INLINE COMMENTS

> broulik wrote in kcm.cpp:88
> Ideally here we would reload the model and then set the newly installed theme 
> as current

I think it should not select the newest installed theme instead of still having 
the current one selected, because in the "Get New..." dialog you can install 
multiple themes and it can't know which of them you actually want.

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D20549

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: davidedmundson, abetts, ngraham, broulik, #vdg, plasma-devel, #plasma, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Reply via email to