davidedmundson added inline comments. INLINE COMMENTS
> volumefeedback.cpp:33 > + > + timer = new QTime(); > + timer->start(); This object leaks. You're better off just making it a member var directly. Also, see QElapsedTimer > volumefeedback.cpp:34 > + timer = new QTime(); > + timer->start(); > } Why? This will block the first noise? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22316 To: kezik, #vdg Cc: davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
