davidedmundson added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:93
> +    // copy kdeglobals (color scheme)
> +    if (!args[QStringLiteral("kdeglobals")].isNull()) {
> +        QDir kdeglobalsSource(args[QStringLiteral("kdeglobals")].toString());

what would happen if:

- there is no /var/lib/sddm/.config yet
- the user hasn't got a fontconfig to copy
- they do have a kdeglobals

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to