davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision.
REVISION SUMMARY QDBusInterface is useful for runtime introspection but little else. As we know the interface in advance we can generate the keyboard layouts interface and have non blocking, easier to read, easier to maintain code. TEST PLAN Opened lock screen, it had the whole list, cycled between them REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D22846 AFFECTED FILES components/keyboardlayout/CMakeLists.txt components/keyboardlayout/keyboardlayout.cpp components/keyboardlayout/keyboardlayout.h components/keyboardlayout/org.kde.KeyboardLayouts.xml To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart