> make it just a widget showing the QuickAccessDialog on click. The toolbar entry would remain the same, to keep explicit it's a general search field
This sounds contradictory to me. Will it be just a button or remain a search field where I can enter the search text? If the former, I am -1 for it. I want to be able to directly enter the search text. Otherwise +1. For sure not something we should change after M3. So, 4.13 candidate. Dani From: Mickael Istria <[email protected]> To: "Eclipse platform general developers list." <[email protected]> Date: 20.05.2019 12:08 Subject: [platform-dev] Replace "Search Field" behavior by just opening Quick Access dialog Sent by: [email protected] Hi all, In https://bugs.eclipse.org/bugs/show_bug.cgi?id=500618 (and a few related ones), there seems to be a consensus building around the idea that the SearchField and more specifically the way user interact with text and table has some pitfalls in term of simplicity of usage, accessibility, maintenance... compared to just showing up the QuickAccessDialog on click. I'd like to start working on the plain removal of all the "smartness" of SearchField, and make it just a widget showing the QuickAccessDialog on click. The toolbar entry would remain the same, to keep explicit it's a general search field, but the filtering and listing proposals would happen in the dialog. This would improve factorization, remove ~600 lines of code, get back to very standard and accessible dialogs, without functional loss. Does anyone have an objection about it? If so, please put them in the bug preferably. -- Mickael Istria Eclipse IDE developer, for Red Hat Developers _______________________________________________ platform-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__www.eclipse.org_mailman_listinfo_platform-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=vZi1HSUxU84ToWtro8Bn56UeahMoZB8FaoYyq6Cq3Qk&s=SxFP-jmoxUB1x5lVz6a_5TphjD1FpvqHHKXt9a3Lysk&e=
_______________________________________________ platform-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
