The change is fine as long as it's local variables (non-escaping) and/or GUI code. Which seems to be the case.
On Mon, Jan 20, 2020 at 4:15 PM Andrey Loskutov <losku...@gmx.de> wrote: > Hi all, > > There is a series of commits that are replacing Vector with ArrayList with > the reasoning "Vector is an outdated data structure and ArrayList should be > preferred > as it is faster". > > Please note, that Vector is synchronized and ArrayList not, so this is not > 1:1 "no-op" exchange! > > As javadoc in Vector says, one could replace it with ArrayList, but only > "If a thread-safe implementation is not needed". > > So whoever is going to review & merge this, please make sure you have > understood the implication of the change on internal & external behavior of > the changed code. > > https://git.eclipse.org/r/156169 > https://git.eclipse.org/r/156179 > https://git.eclipse.org/r/156172 > https://git.eclipse.org/r/156170 > https://git.eclipse.org/r/156166 > https://git.eclipse.org/r/156167 > https://git.eclipse.org/r/156168 > https://git.eclipse.org/r/156171 > > Kind regards, > Andrey Loskutov > > Спасение утопающих - дело рук самих утопающих > > https://www.eclipse.org/user/aloskutov > > _______________________________________________ > platform-dev mailing list > platform-dev@eclipse.org > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev -- Best regards, Nikita Nemkin
_______________________________________________ platform-dev mailing list platform-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
