I stop discussions on the topic here. Discussion should be at https://bugs.eclipse.org/bugs/show_bug.cgi?id=567906
On Thu, Oct 15, 2020 at 7:00 PM Thomas Singer <ts-...@syntevo.com> wrote: > We build SWT on our own using just these 2 SWT repositories. Will that > version be correct in this case, too? In other words, this would mean > that the 'official 4.16 version' somewhere is stored in these SWT > repositories. > > -- > Best regards, > Thomas Singer > > > On 2020-10-15 17:20, Aleksandar Kurtakov wrote: > > On Thu, Oct 15, 2020 at 6:13 PM Gregor Schmid <gschm...@qfs.de> wrote: > > > >> > >> Hi all, > >> > >> the number 4.940 in version.txt has only just become meaningless - see > >> the recent discussion about "Inconsistent version change in SWT 4.18" > >> and the associated closed bug report > >> > >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=567789 > >> > >> In that discussion Tom mentioned the Manifest file as an alternative > >> and I'm investigating that. Thanks Aleksandar, for moving that > >> forward. > >> > >> So I'm also curious about the Implementation-Version in the Manifest > >> file. Does that have a well-defined meaning? > > > > > > It should be the version as specified in the OSGi manifest - > > > https://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/bundles/org.eclipse.swt/META-INF/MANIFEST.MF > > . I notice that it is wrong with my patch so I have to look further at > what > > needs fixing. > > > > > >> Is it documented > >> somewhere? Is it reliable? > >> > > > > It's 100% reliable as we have tools that verify that OSGi metadata is > good > > and bumped when a change happens. > > > > > >> > >> If not, wouldn't it be a good idea to have both "4.18" and "2020-12" > >> added to the Manifest file and/or as constants at some well-defined > >> location like the Library class or the version.txt file? > >> > > > > I wouldn't mind having eclipse sdk version (4.18) in the manifest too. It > > is the best place according to me for such metadata. Just have to play > with > > the build system to make sure it's fetched from the main build and not > > hardcoded to prevent shipping wrong content. > > > > > >> > >> My suggestion to use a map to deduct the user-visible version from > >> whatever inconsistent version number is embedded in the code was > >> actually a joke. If that's the only way, so be it, but from a software > >> engineering standpoint I still vote for something predictable :-). > >> > >> Best regards, > >> Greg > >> > >> Thomas Singer <ts-...@syntevo.com> writes: > >> > >>> Hi Aleksandar, > >>> > >>> Do you mean > >>> > >>>> Manifest-Version: 1.0 > >>>> Ant-Version: Apache Ant 1.10.9 > >>>> Created-By: 11.0.2+9 (Oracle Corporation) > >>>> SWT-OS: linux > >>>> SWT-WS: gtk > >>>> SWT-Arch: x86_64 > >>>> Implementation-Version: 3.113.0 > >>> > >>> Should I find there something like "4.16"? The version.txt still shows > >>> "version 4.940". It's all a little bit confusing. > >>> > >>> -- > >>> Best regards, > >>> Thomas Singer > >>> > >>> > >>> > >>> On 2020-10-15 16:04, Aleksandar Kurtakov wrote: > >>>> Thomas, would you please look at > >>>> > >> > https://ci.eclipse.org/platform/job/eclipse.platform.swt-Gerrit/1815/artifact/eclipse.platform.swt.binaries/bundles/org.eclipse.swt.gtk.linux.x86_64/target/swt-I20201015-1352-gtk-linux-x86_64.zip > >>>> and the swt.jar/manifest.mf in it. If this works for you I'll push and > >> it > >>>> will be available starting tomorrow build. > >>>> > >>>> On Thu, Oct 15, 2020 at 4:06 PM Aleksandar Kurtakov < > >> akurt...@redhat.com> > >>>> wrote: > >>>> > >>>>> > >>>>> > >>>>> On Thu, Oct 15, 2020 at 3:28 PM Thomas Singer <ts-...@syntevo.com> > >> wrote: > >>>>> > >>>>>> Hi Aleksander, > >>>>>> > >>>>>> Thanks for the link. Now the problem remains how to map between the > >>>>>> content of the version.txt inside the org.eclipse*.jar to the > >>>>>> Eclipse/SWT version. For example, my version.txt contains the > >>>>>> information "version 4.940". Which is the corresponding Eclipse/SWT > >>>>>> version? > >>>>>> > >>>>> > >>>>> Frankly, this questions I can't easily answer. I've opened > >>>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=567906 to use > >>>>> Implementation-Version in the manifest for that. > >>>>> > >>>>>> > >>>>>> -- > >>>>>> Best regards, > >>>>>> Thomas Singer > >>>>>> > >>>>>> > >>>>>> On 2020-10-15 13:38, Aleksandar Kurtakov wrote: > >>>>>>> On Thu, Oct 15, 2020 at 2:27 PM Thomas Singer <ts-...@syntevo.com> > >>>>>> wrote: > >>>>>>> > >>>>>>>> Hi all, > >>>>>>>> > >>>>>>>> How can I find out which Eclipse/SWT release is supposed to > support > >>>>>>>> which platforms, especially which Linux versions? Thanks in > advance. > >>>>>>>> > >>>>>>> > >>>>>>> https://www.eclipse.org/swt/faq.php#gtkstartup - lists the mapping > >>>>>> between > >>>>>>> gtk and swt versions. > >>>>>>> > >>>>>>> > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> Tom > >>>>>>>> _______________________________________________ > >>>>>>>> platform-dev mailing list > >>>>>>>> platform-dev@eclipse.org > >>>>>>>> To unsubscribe from this list, visit > >>>>>>>> https://www.eclipse.org/mailman/listinfo/platform-dev > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> _______________________________________________ > >>>>>>> platform-dev mailing list > >>>>>>> platform-dev@eclipse.org > >>>>>>> To unsubscribe from this list, visit > >>>>>> https://www.eclipse.org/mailman/listinfo/platform-dev > >>>>>>> > >>>>>> _______________________________________________ > >>>>>> platform-dev mailing list > >>>>>> platform-dev@eclipse.org > >>>>>> To unsubscribe from this list, visit > >>>>>> https://www.eclipse.org/mailman/listinfo/platform-dev > >>>>>> > >>>>>> > >>>>> > >>>>> -- > >>>>> Alexander Kurtakov > >>>>> Red Hat Eclipse Team > >>>>> > >>>> > >>>> > >>>> > >>>> _______________________________________________ > >>>> platform-dev mailing list > >>>> platform-dev@eclipse.org > >>>> To unsubscribe from this list, visit > >> https://www.eclipse.org/mailman/listinfo/platform-dev > >>>> > >>> _______________________________________________ > >>> platform-dev mailing list > >>> platform-dev@eclipse.org > >>> To unsubscribe from this list, visit > >> https://www.eclipse.org/mailman/listinfo/platform-dev > >>> > >> > >> -- > >> Gregor Schmid > >> > >> E: gregor.sch...@qfs.de > >> T: +49 8171 38648-11 > >> F: +49 8171 38648-16 > >> > >> Quality First Software GmbH | www.qfs.de > >> Tulpenstr. 41 | 82538 Geretsried | Germany > >> GF Gregor Schmid, Dr. Martina Schmid, Karlheinz Kellerer > >> HRB München 140833 > >> > >> The data protection information in accordance with the EU General Data > >> Protection Regulation applies to authorized representatives / > >> authorized representatives of "legal persons" in accordance with Art. > >> 12 ff. DS-GVO > >> https://www.qfs.de/fileadmin/Webdata/pdf/en/dsgvo.pdf > >> _______________________________________________ > >> platform-dev mailing list > >> platform-dev@eclipse.org > >> To unsubscribe from this list, visit > >> https://www.eclipse.org/mailman/listinfo/platform-dev > >> > > > > > > > > _______________________________________________ > > platform-dev mailing list > > platform-dev@eclipse.org > > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev > > > _______________________________________________ > platform-dev mailing list > platform-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev > -- Alexander Kurtakov Red Hat Eclipse Team
_______________________________________________ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
