> On 20 Oct 2020, at 17:30, Mickael Istria <mist...@redhat.com> wrote:
>
>
>
> On Tue, Oct 20, 2020 at 6:23 PM Alex Blewitt <alex.blew...@gmail.com
> <mailto:alex.blew...@gmail.com>> wrote:
> I accidentally pushed to master in the platform debug repository in a change
> that I thought I’d configured for Gerrit:
> https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=5c202200d26fa8f0fb07c46d3f92f5e4338b2f32
>
> <https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=5c202200d26fa8f0fb07c46d3f92f5e4338b2f32>
> What’s the process for resolving this commit? Should I commit a revert
> backing out the change and go through the Gerrit review?
>
> If it's a desirable change, let's just keep it ;)
> If not (ie it introduces regression or test issues), I think it's OK if you
> just push directly a revert commit.
OK … I had built it and then done a git pull, so I’d changed the base. I’m
concerned that I may have inadvertently broken the build, particularly if it
needed version updates in the manifest etc.
Do you know where the master build branch is? I couldn’t see it obviously on
ci.eclipse.org <http://ci.eclipse.org/>.
> Gerrit is highly recommended and brings a lot of quality assessment, but
> committers are free to bypass it when it seems to be the best path forward
> (eg if it prevents from upcoming build failures).
If the build is broken, I’ll need to push a revert.
Alex
_______________________________________________
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev
