> On 23 Mar 2021, at 10:58, Sebastian Zarnekow <[email protected]>
> wrote:
>
> Hi Alex,
>
> given the long explanation for the issue and the impact such a change might
> have on downstream consumers along with the scray feeling that I have about
> code like
>
> public class Workspace .. {
> /**
> * Used by ResourcesPlugin to identify the workspace, not for other uses.
> */
> public static IWorkspace singleton;
> ..
> }
To be fair, that’s just what the ResourcesPlugin does at the moment:
https://github.com/eclipse/eclipse.platform.resources/blob/7fc856229a1e26eae354adf70d11b39d6727c20e/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/ResourcesPlugin.java#L350-L356
<https://github.com/eclipse/eclipse.platform.resources/blob/7fc856229a1e26eae354adf70d11b39d6727c20e/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/ResourcesPlugin.java#L350-L356>
It was a refactoring that essentially moved it from ResourcesPlugin.workspace
to Workspace.workspace for better locality. This is where it initialises the
static singleton at the moment:
https://github.com/eclipse/eclipse.platform.resources/blob/7fc856229a1e26eae354adf70d11b39d6727c20e/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/ResourcesPlugin.java#L464
Alex
_______________________________________________
platform-dev mailing list
[email protected]
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev
