On Thu, Mar 24, 2022 at 3:01 PM Sravan K Lakkimsetti < sravankum...@in.ibm.com> wrote:
> >> It is unclear / undocumented how to *properly* refer to bugs in commits > (full url? repo-name/id? just id?). > >> It is unclear if we should now use dedicated github bug trackers *per > repository* to report bugs, or will be there some higher level bug tracker > for entire platform organization? > > > > Here are my suggestions on this. > > 1. All the commits should have an issue, created in the same > repository, number associated with them > 1. <description of change> #<issue number> > > I don't think it is necessary to have issues for each commit(more of an PR as it may be multiple commits). With Github PR and issue are practically the same in terms of references (even share the same number sequence). If the concern is that PR is not reopenable it's better to open an issue later if there is an actual issue with the PR rather than create really empty issues that just hold reference to PR. > > 1. > 1. For root level issues like work spanning across multiple > repositories, I would prefer root bugs to be created in > 1. Platform in https://github.com/eclipse-platform/eclipse.platform > 2. Equinox in https://github.com/eclipse-equinox/equinox.framework > 3. Pde in eclipse.pde.ui > 4. Jdt in https://github.com/eclipse-jdt/eclipse.jdt > 2. If issues span across multiple projects(organizations), my > preference would be > https://github.com/eclipse-platform/eclipse.platform > > > > Thanks > > Sravan > > *From:* platform-dev <platform-dev-boun...@eclipse.org> *On Behalf Of *Mickael > Istria > *Sent:* 24 March 2022 17:40 > *To:* Eclipse platform general developers list. <platform-dev@eclipse.org> > *Subject:* [EXTERNAL] Re: [platform-dev] Github workflow > > > > Hi, I'm putting a few answers here, but those could go to the document > pointed out by Sravan (which by the way could be renamed to > CONTRIBUTING.md) I don't like forks and used to have branches on main > repo - not recommended. ZjQcmQRYFpfptBannerStart > > This Message Is From an External Sender > > This message came from outside your organization. > > ZjQcmQRYFpfptBannerEnd > > Hi, > > > > I'm putting a few answers here, but those could go to the document pointed > out by Sravan (which by the way could be renamed to CONTRIBUTING.md) > > > > I don't like forks and used to have branches on main repo - not > recommended. > > > > Indeed. The "upstream" repo shouldn't be used as a workspace for ongoing > work. Your workspace is your fork. > > > > I don't like multiple commits in one PR and always use amend/force push - > not recommended. > > > > That's *not* not recommended. It's just something that is up to the > submitter, we shouldn't recommend anything here and let contributors build > the workflow they prefer. > > What needs to be recommended is how we merge and keep a meaningful > granularity for commits, not how contributors submit their PRs. > > > > I never use command line git and do everything from Eclipse - but some > recommended to use git CLI. > > > > What typical commands do you have in mind? GitHub really is standard Git > when it comes to push/fetch, the only thing to know is that reference to > fetch/merge a PR is `pulls/123/head`, so there is no Git fanciness needed > and EGit can be used for most operations. The only operation needed is the > creation of a pull request and its review, that usually happens via an > external tool (eg GitHub website). > > > > Egit support missing or not - not clear. What exactly is missing, why CLI > is needed? > > > > There is decent support for GitHub in EGit. If anything is missing, it > should be reported to EGit. > > > > It is unclear / undocumented how to *properly* refer to bugs in commits > (full url? repo-name/id? just id?). > It is unclear if we should now use dedicated github bug trackers *per > repository* to report bugs, or will be there some higher level bug tracker > for entire platform organization? > > > > I believe that is still to be determined, as we're growing collective > experience here. > > > > Once the PR is created, I see that builds somehow triggered in equinox, > but I neither get mails that they are stared nor they are finished. > > > > That's an interesting thought. I don't know whether there is some option > to allow email notifications for votes. > > > _______________________________________________ > platform-dev mailing list > platform-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev > -- Aleksandar Kurtakov Red Hat Eclipse Team
_______________________________________________ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
