I haven't followed the full discussion but remember we have enabled that
one can only rebase/ff merges? So doing this in the verification build
is not *that* bad per se.
Beside that, for Tycho we have enabled that drafts are not build and
that helps to a certain degree to keep the list of active PRs low as one
don't want to waste the time for PRs that are not actively developed on.
So there are pro and cons for both strategies.
Am 27.04.22 um 11:26 schrieb Andrey Loskutov:
Hi,
In [1] I've stumbled on a weird Jenkins / github feature that tried to
automatically merge & rebuild your PR if master branch had new commits.
Not only that caused extra load on limited jenkins resources, it also didn't
actually test *your* PR 1:1 as you would expect, but some merged state on top
of origin branch HEAD commit. It might be useful in some cases, but I
personally expect that system tests what I've submitted, not what the system
merges for me and assumes that that's fine.
This was also recommended action in [2]:
"We also recommend to change the 'Discover pull requests from origin' and 'Discover
pull requests from forks' strategies from 'Merging the pull request with the current
target branch revision' to 'The current pull request revision'. This would prevent a
rebuild on reindexing if the target branch has changed since last commit"
... but was only done for one single job.
So I took the freedom to change this settings for all github jobs I've found in
platform/jdt/pde/equinox CI instances (https://ci.eclipse.org/platform/,
https://ci.eclipse.org/jdt/, https://ci.eclipse.org/pde/,
https://ci.eclipse.org/equinox/).
[1]
https://github.com/eclipse-jdt/eclipse.jdt.core/pull/38#issuecomment-1109908918
[2] https://www.eclipse.org/lists/platform-dev/msg03542.html
Kind regards,
Andrey Loskutov
Спасение утопающих - дело рук самих утопающих
https://www.eclipse.org/user/aloskutov
_______________________________________________
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev
_______________________________________________
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev
