On Thu, Aug 18, 2011 at 05:04:08PM +0800, AceLan Kao wrote:
> +static void dell_touchpadled_on()
> +{
> + while (inb(0x64) & 0x02)
> + msleep(20);
> + outb(0x97, 0x64);
> +
> + while (inb(0x64) & 0x02)
> + msleep(20);
> + outb(1, 0x60);
> +
> + touchpad_led_status = 1;
> +}
No. You're hitting the keyboard controller without any coordination with
the i8042 driver. What happens if the user hits a key while you're in
the middle of this?
> + * Called for each KEY_F22 key press event.
> + */
> +static void dell_touchpadled_update(struct work_struct *work)
> +{
> + touchpad_led_status = 1 - touchpad_led_status;
> +
> + if (touchpad_led_status == 1)
> + dell_touchpadled_on();
> + else
> + dell_touchpadled_off();
> +}
No, this should be handled in userspace. Expose the LED via the LED
class and have gnome-settings-daemon (or equivalent) coordinate the
policy - otherwise you'll end up with situations where userspace and the
LED state are out of sync.
--
Matthew Garrett | [email protected]
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
