On 11/29/2012 09:02 AM, Corentin Chary wrote: > On Thu, Nov 29, 2012 at 2:46 AM, <[email protected]> wrote: >> From: marxin <[email protected]> >> >> --- >> drivers/iio/industrialio-buffer.c | 4 +- >> drivers/staging/iio/light/Kconfig | 6 + >> drivers/staging/iio/light/Makefile | 1 + >> drivers/staging/iio/light/acpi-als.c | 486 >> ++++++++++++++++++++++++++++++++++ >> 4 files changed, 495 insertions(+), 2 deletions(-) >> create mode 100644 drivers/staging/iio/light/acpi-als.c >> >> diff --git a/drivers/iio/industrialio-buffer.c >> b/drivers/iio/industrialio-buffer.c >> index aaadd32..b8b377c 100644 >> --- a/drivers/iio/industrialio-buffer.c >> +++ b/drivers/iio/industrialio-buffer.c >> @@ -119,8 +119,8 @@ static ssize_t iio_scan_el_show(struct device *dev, >> int ret; >> struct iio_dev *indio_dev = dev_to_iio_dev(dev); >> >> - ret = test_bit(to_iio_dev_attr(attr)->address, >> - indio_dev->buffer->scan_mask); >> + ret = !!(test_bit(to_iio_dev_attr(attr)->address, >> + indio_dev->buffer->scan_mask)); > > It's strange that you have to do that. > Can you give use the exact values that make test_bit return something > else that 1 or 0 ? > Maybe there is a bug to fix in test_bit here.
Even if this was a bug in IIO this should be in a separate patch. > >> >> return sprintf(buf, "%d\n", ret); >> } [...] -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
