On Saturday 21 November 2015 01:29:04 Darren Hart wrote:
> Pali, was this something you wanted to discuss more before I merge
> it?

Just one note:

> +             if (keycode == 0) {

What about using define KEY_RESERVED instead hardcoded constant 0?

> +                     pr_info("firmware scancode %d maps to unrecognized 
> keycode %d\n", bios_entry->keycode, bios_entry->scancode);
> +                     continue;
> +             }

-- 
Pali Rohár
pali.ro...@gmail.com

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to