Patryk Zawadzki wrote: > It's not a valid URI to put in spec. Not if you want to be able to > freely switch between different URI schemas (http:// vs. ftp:// is a > good enough example). > Do we need this? Where and for what?
> In http schema the "?" character serves the purpose of separating a > document name from a query string. Therefore the question mark is not > part of the document requested, it's there to pass additional > parameters to the http server. It should also not be saved as part of > the file name. The file name should be derived from either response > headers (for example "Disposition" headers allows one to set the > desired file name) or the server's document name (the part between the > last "/" and "?"). wget behaves differently and saves the question > mark as part of the file name which is required for wget's teleport > mode to work (where you request a full website mirror locally). > > Even if you asked wget to behave like a usual web browser (and thus > have the correct file name on distfiles), the builder script still has > no idea what name to search for (as the web server is free to pass any > file name in the response headers). > I know that and this only explains why wget saves files with everything after "?" and also explains why we don't use name given by webbrowser. This is obvious. But this still doesn't explain why you refuse to serve wget encoded name part of URL when downloading from distfiles (especially when builder script could even distinguish if file was downloaded from http or ftp because it has such information in spec - but this is not required). Please tell me what this will brake. What will/could fail after encoding name when getting files from distfiles? For me this is correct fix i don't understand why You telling its not? I just want some example;) > If you want to fix anything, I'd suggest fixing the spec by using an > unambiguous URI. Its not unambiguous, its correct. If I write at the beginning http then its obvious that this is a http:// URI. If I will write ftp:// then its obvious that this will be a ftp URI. Builder also has this information and could even decide what to do when getting files from distfiles. -- Regards, Kamil Dziedzic
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
