bird-1.5.0-1.x86_64 crasches quite often on reconfiguration including renaming BGP protocols due to bad set of CFLAGS passed on compilation

[Bartek Radwan]

bird-1.5.0-1.x86_64 crasches quite often on reconfiguration including 
renaming BGP protocols due to bad set of CFLAGS passed on compilation

Hi PLD Developers,
I'm running two bird instances serving mostly as BGP routers, both of 
them have several BGP sessions setablished.
Few days ago i've renamed some of the protocols to reflect comapny 
naming standards.

This massive reconfiguration caused segfault of bird.

Bird developers did not reproduced this error with fresh 1.5.0 [1], so 
i've stgarted to look for differences during build time between vanilla 
bird and PLD bird - the difference is in CFALGS passed during build.

Bird vanilla has been adding  -fno-strict-overflow and 
-fno-strict-aliasing for about three years [2], and as far as i can see 
adding them (attached patch) to CFLAGS provided by PLD fixes the problem.

Ondrej Zaicek says:

Although -fwrapv more-or-less supersedes
-fno-strict-overflow, so just with -fno-strict-aliasing should work too.

but attached ptach adds -fno-strict-overflow too just to be more 
consistent with bird mainstream.


1. http://trubka.network.cz/pipermail/bird-users/2016-March/010270.html
2. 
https://gitlab.labs.nic.cz/labs/bird/commit/efd6d12b975441c7e1875a59dd9e0f3db7e958cb


--
Regards,
Bartek
diff --git a/bird.spec b/bird.spec
index 1d09f35..ddcfce3 100644
--- a/bird.spec
+++ b/bird.spec
@@ -10,7 +10,7 @@ Summary:	The BIRD Internet Routing Daemon
 Summary(pl.UTF-8):	Demon BIRD Internetowego Routingu Dynamicznego
 Name:		bird
 Version:	1.5.0
-Release:	1
+Release:	2
 License:	GPL v2+
 Group:		Networking/Daemons
 Source0:	ftp://bird.network.cz/pub/bird/%{name}-%{version}.tar.gz
@@ -114,7 +114,7 @@ filtrów o dużych możliwościach.
 cp -f /usr/share/automake/config.* tools
 %{__autoconf}
 
-export CFLAGS="%{rpmcflags} -I%{_includedir}/ncursesw"
+export CFLAGS="%{rpmcflags} -I%{_includedir}/ncursesw -fno-strict-aliasing -fno-strict-overflow"
 
 %if %{with ipv6}
 %configure \
_______________________________________________
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en