Hi,

> On 2009-02-08 08:18-0800 Alan W. Irwin wrote:
> 
> If you have a 64-bit system (especially Mac OS X and Windows since I don't
> have access to those platforms), please give the above test a try. I suspect
> it will build and run out of the box on Mac OS X.  It's probable some
> additional work will be required to build the test on Windows. If it turns
> out such a build is not possible on Windows, you should bypass
> the build of qsastime_testlib in our CMake build system file,
> lib/qsastime/CMakeLists.txt, by modifying that build logic as follows:
> 
> if(NOT WIN32)
>    add_executable(qsastime_testlib qsastime_testlib.c)
>    target_link_libraries(qsastime_testlib qsastime)
> endif(NOT WIN32)
> 
> Alan
>

Compiling qsastime etc with MSVC 9 and cygwin gcc 3.4 showed some errors-

1. plplot-dev/lib/qsastime/qsastime.c:282: warning: assignment
   makes integer from pointer without a cast
   plplot-dev/lib/qsastime/qsastime.c:285: warning: assignment
   makes integer from pointer without a cast

   In both these cases, year should be dereferenced ie *year.
 

2. ..\..\..\..\lib\qsastime\qsastime_testlib.c(58) : warning C4244:   
   'return' : conversion from 'time_t' to 'int', possible loss of data

   I think  my_timegm is meant to be defined in line 44 as 
      time_t my_timegm(struct tm *tm) 

3. plplot-dev\lib\qsastime\qsastime_testlib.c(128) : warning C4700:
    uninitialized local variable 'secs1' used
   plplot-dev\lib\qsastime\qsastime_testlib.c(144) : warning C4700:
    uninitialized local variable 'secs1' used

   In both these cases secs1 should be sec1

4. qsastime_testlib cannot be built with MSVC 2008 as setenv and unsetenv 
    are not implemented. 

A patch for items 1-3 above is attached. However due to 4 the above changes
are untested. 


Kind regards


Terrence


      

Attachment: plplot-9498.patch
Description: Binary data

------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to