I don't recall explicitly adding this, so I imagine it was something that
came from the previous incarnation of the C++ bindings. There is an
example xform linear transformation in utils/xform.c. Perhaps this was
originally in the main library. Actually bindings/swig/plplotcapi.i still
also mentions xform.
I agree that we should probably just remove these. I've commented them
out for now rather than actually deleting them.
Andrew
On Mon, Mar 16, 2009 at 03:38:40PM +0100, Arjen Markus wrote:
> Hi Werner,
>
> is there any reference to an (example) linear transformation?
> If not, I'd say: remove it.
>
> It seems an attempt to call a similar C function, but I know of
> no such functionality ... I am inclined to repeat my suggestion
> also in the case there is a reference.
>
> Regards,
>
> Arjen
>
> On 2009-03-16 15:32, Werner Smekal wrote:
> > Hi,
> >
> > in the process of removing all warnings the Visual C++ compiler put out
> > (which turned out to be a good thing, since I could remove some
> > (potential) bugs), I also found some problem in plstream.cc where I'm
> > not sure what the purpose of the code is/was.
> >
> > The Visual C++ compiler puts out the following warning:
> >
> > [ 51%] Building CXX object
> > bindings/c++/CMakeFiles/plplotcxxd.dir/plstream.cc.obj
> > plstream.cc
> > z:\devzone\pldev\plplot\bindings\c++\plstream.cc(2269) : warning C4717:
> > 'plstream::xform' : recursive on all control paths, function will cause
> > runtime stack overflow
> >
> > The relevant code part is:
> >
> > /* Example linear transformation function for contour plotter. */
> >
> > void plstream::xform( PLFLT x, PLFLT y, PLFLT * tx, PLFLT * ty )
> > {
> > set_stream();
> >
> > xform(x,y,tx,ty);
> > }
> >
> > I wasn't able to find any declaration of xform, apart from
> > plstream::xform. So this code as Visual C++ warns calls itself
> > recursively until there is an stack overflow. I'm quite sure we never
> > use this functions anywhere, but we should either remove it, or correct it.
> >
> > Any proposes what to do?
> >
> > Regards,
> > Werner
> >
>
>
> Delft Hydraulics, GeoDelft, the Subsurface and Groundwater unit of TNO and
> parts of Rijkswaterstaat have joined forces in a new independent institute
> for delta technology, Deltares. Deltares combines knowledge and experience in
> the field of water, soil and the subsurface. We provide innovative solutions
> to make living in deltas, coastal areas and river basins safe, clean and
> sustainable.
>
>
>
> DISCLAIMER: This message is intended exclusively for the addressee(s) and may
> contain confidential and privileged information. If you are not the intended
> recipient please notify the sender immediately and destroy this message.
> Unauthorized use, disclosure or copying of this message is strictly
> prohibited.
> The foundation 'Stichting Deltares', which has its seat at Delft, The
> Netherlands, Commercial Registration Number 41146461, is not liable in any
> way whatsoever for consequences and/or damages resulting from the improper,
> incomplete and untimely dispatch, receipt and/or content of this e-mail.
>
>
>
>
>
> ------------------------------------------------------------------------------
> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
> easily build your RIAs with Flex Builder, the Eclipse(TM)based development
> software that enables intelligent coding and step-through debugging.
> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
> _______________________________________________
> Plplot-devel mailing list
> Plplot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel
