On Sat, Jul 04, 2009 at 08:14:27AM +0300, Dmitri Gribenko wrote: > On Fri, Jun 19, 2009 at 5:57 PM, Dmitri Gribenko<griboz...@gmail.com> wrote: > > There's actually no need in NEED_PLDEBUG (include/pldebug.h). > > pldebug() can be declared inline and that will silence warnings about > > pldebug() being unused. ?'inline' keyword is from C99. ?If it is a > > concern that some C compilers may not support 'inline' (but most > > modern compilers do), then an appropriate check can be added to the > > build system. > > > > The attached patch does what is described above. > > Hello, > > Anything wrong with that patch? > > Dmitri
Dmitri, Your patch is fine for compilers which support C99 (or at least inline). We tend to be conservative about assuming such support in the core library since one of the great benefits of plplot is that it is very portable. A quick web search suggests that inline is not available for C code in Visual Studio 2003 for example. A cmake check for inline could get round this issue. Perhaps those with non-gcc compilers could comment on the availability of "inline". Thanks Andrew ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/blackberry _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
