Alan W. Irwin wrote: > Hi Alban: > > I split your big patch into two commits for more clarity about what you did. > Revision 10195 is your patch without the whitespace changes and revision > 10196 completes your patch with the (extensive) whitespace changes. > > Since this patch changes a lot (even if you discount the whitespace > changes), I have given it a thorough testing by running both "make > test_interactive" and "make test_noninteractive" in the installed examples > using the new build system there. These tests were all done with the > downloaded Qt4.5.1 SDK. > > For the test_interactive case I looked carefully at all the qtwidget results > for all our examples and the qt_example result. For -dev qtwidget all seems > well except that device still treats example 17 in a "noninteractive" way. I > have written you separately about that issue. I also noticed your solution > to the initial background colour for qt_example plus the different > background color you have imposed for the Curves plot. > > One additional issue for qt_example is I would really like to see access to > the PLplot command-line arguments for that example. To make that happen, > a call to plparseopts should be inserted just before the call of > plinit(); in qt_PlotWindow.cpp. However, the typical plparseopts call, > e.g., > > plparseopts( &argc, argv, PL_PARSE_FULL ); > > doesn't work because there is no access (as far as I can tell) to argc and > argv at that place in the code. Could you advise on how to get that access? > > For the test_noninteractive case, I used the ImageMagick "display" > application to look at all 1040 (!) files generated by each of the qt > non-interactive devices for each of the pages of our standard examples. I > may have missed something because that is _a lot_ of viewing, but everything > looked fine. > > Alan > __________________________ > Alan W. Irwin > > Astronomical research affiliation with Department of Physics and Astronomy, > University of Victoria (astrowww.phys.uvic.ca). > > Programming affiliations with the FreeEOS equation-of-state implementation > for stellar interiors (freeeos.sf.net); PLplot scientific plotting software > package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of > Linux Links project (loll.sf.net); and the Linux Brochure Project > (lbproject.sf.net). > __________________________ > > Linux-powered Science > __________________________ > Hi Alan,
Thanks for your feedback, and good luck with your image comparisons :) I put these issues as well as the clearWidget/FLUSH remarks on my to-do list and I will come back with a patch a little later. Alban ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Plplot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/plplot-devel
