On 2009-10-22 16:07-0500 Hezekiah M. Carty wrote: > Alan, > > While reading through the reformatted C in the OCaml bindings portion > of your recent uncrustify commits, I noticed a small inconsistency. > When a function call ends with "));", not extra space is added to make > this ") );". This seems to be consistent throughout the rest of the > reformatted C source code. > > I see that the relevant setting in uncrustify.cfg (sp_paren_paren) is > set to remove these spaces. Is there a reason for this? While > reading through the changes I found the new formatting hindering my > visual tracking through the code. > > If there are no objections I would like this option changed to include > spaces between )) and ((. My apologies for not bringing this up > sooner - I had not noticed this issue in the reformatted C before now.
Hi Hez: No objections here, but I don't care about style that much so long as it is consistent. While you are waiting for comments from others, I suggest (in case you haven't done this already) you download, build, and install uncrustify 0.53 and then run scripts/style_source.sh --diff -au |less to see the complete effect of your proposed change to uncrustify.cfg on all our C source code (and some of our C++ code) without actually modifying those files. Use the --help option for the script to see how to specify other diff options and/or eventually apply your proposed style changes to our source code. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
