On 2014-03-13 22:30-0000 Andrew Ross wrote: > On Wed, Mar 12, 2014 at 02:28:16PM -0700, Alan Irwin wrote: >> @Andrew: It is great that you have access to Qt5. Also because of >> your high degree of expertise concerning our build system, I encourage >> you to just go ahead and make any further Qt5-related build-system >> changes that are required yourself rather than waiting for me to pass >> judgement on what you think is necessary. > > Alan, > > I tried this evening. I ran into a couple of problems. Firstly Debian > still has Qt 5.2.0. Simple to change the version searched for. This got > me a bit further, but cmake then failed with > > CMake Error at src/CMakeLists.txt:218 (set_qt_target_properties): > Unknown CMake command "set_qt_target_properties". > > Debian also still has cmake 2.8.12.1 if this is relevant. > > Looks like this function is only defined for Qt4, not Qt5 [...]
True. This Qt4-only function should never be called for the Qt5 case, and I have fixed that issue (good catch by the way) for revision 13053. > and there will > be some work to do sorting out include directories and libraries. That should all be taken care of (according to the Qt5 cmake manual <http://doc-snapshot.qt-project.org/qt5-stable/cmake-manual.html> with the logic block above that starts if(NOT ENABLE_DYNDRIVERS AND ANY_QT_DEVICE AND PLPLOT_USE_QT5) I am using the CMake-2.8.9 part of that manual which basically says the qt5_use_modules command should take care of all these issues. But I may be misreading/misinterpreting that manual so would you take a look at that manual as well? > Commenting > out the call to this function for QT5 leads to the build failing since it > can't find the Qt5 header files. I don't understand that result (which for the Qt5 case is equivalent to my fix) since RM got a lot further, but he apparently used the default dynamic devices while you have specifically requested static devices for some reason with -DENABLE_DYNDRIVERS=OFF which triggered the bad call to set_qt_target_properties for the Qt5 case which has now been fixed. Since static devices are always a bit tricky, could you use the dynamic devices to start with at least? Of course, you should also follow my suggestion to RM that he set -DPLD_epsqt=OFF to exclude PostScript-relevant code that is not supported by Qt5. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
