Hi Alan, I will test this as soon as possible - that may be tomorrow. I did not know the %zu format code and from what I have seen in a few posts on MSVC, that will never support C99 in full - the compiler is called MS VC++ nowadays and the support for C code (not C++) is partly there for historical reasons (my nutshell of wisdom comes from: http://herbsutter.com/2012/05/03/reader-qa-what-about-vc-and-c99/).
I noted that your request involves testing both the in-build and the installed versions. Regards, Arjen -----Original Message----- From: Alan W. Irwin [mailto:ir...@beluga.phys.uvic.ca] Sent: Wednesday, May 21, 2014 1:04 AM To: Arjen Markus; PLplot development list Subject: Re: [Plplot-devel] revision 13125 needs Cygwin testing On 2014-05-20 12:21-0700 Alan W. Irwin wrote: > Hi Arjen: > > Please test revision 13125 on Cygwin. > > That revision changes a -debug printf specifier for size_t from %zu > (the c99 standard) to %lu for the Microsoft case as specified by the > Microsoft documentation of how size_t values must be formatted (since > they don't support %zu). > > This change fixes a bug for the "MinGW Makefiles" case where the > -debug option was giving gibberish for the length of filename strings. > > However, I am not sure this code will work properly on Cygwin. Does > %zu work for that platform of %lu or both? Is the WIN32 macro > #defined on Cygwin? Instead of answering those questions > individually, it might be better to simply test build-tree results on Cygwin > as follows: > > examples/c/x00c -dev psc -debug -o test.ps > > For the MinGW/Wine case ("MinGW Makefiles" generator) I get the > following debugging output from that command: > > plLoadDriver: Device not loaded! > plLoadDriver: tag=psc, drvidx=0 > plLoadDriver: Trying to load ps on ps > plGetName: Maximum length of full pathname of file to be found is 116 > plGetName: Full pathname of file to be found is > z:/home/wine/newstart/build_script/build_dir-1.6.1_mingw/epa_build/Sou > rce/build_plplot\data\cmap0_default.pal > plLibOpenPdfstr: Found file > z:/home/wine/newstart/build_script/build_dir-1.6.1_mingw/epa_build/Sou > rce/build_plplot\data\cmap0_default.pal > [...] > > Before the bug fix that 116 was gibberish in the MinGW case since > Microsoft does not recognize the c99 %zu format specifier for size_t. > > If the Cygwin build has no compiler warnings for plGetName and that > test on Cygwin also gives a reasonable number for the maximum pathname > length (normally 7 larger than the actual pathname length), then no > further fiddling has to be done with the plGetName function defined in > src/plctrl.c. > > I don't think specific tests have to be done for the MSVC case since > there is no question in that case that the WIN32 macro is #defined and > the %lu format specifier used in that case should work just like it > currently does for the MinGW case. Hi Arjen (and others here with access to either/both Cygwin and/or MSVC): I similarly request testing of revision 13126 by executing the same command as above in the build tree and also in the install tree. If the revised code in the function plInBuildTree defined in src/plcore.c is correct, the build-tree version (as in the results above) should find source-tree versions of all data files such as z:/home/wine/newstart/build_script/build_dir-1.6.1_mingw/epa_build/Source/build_plplot\data\cmap0_default.pal above. Also, the install-tree version should find install-tree versions of those files. Note at the present time I have only done build-tree testing of revision 13126 on MinGW/Wine (as above) and Linux, but I plan to follow that up with both build-tree and install-tree testing on Linux, MinGW/Wine, and MinGW/MSYS/Wine. My Linux platform testing will probably be sufficient for all Unix platforms including Mac OS X, but I request similar tests of revision 13126 for the Cygwin and MSVC platforms (both of which are unavailable to me and which may respond in unanticipated ways to the code updates I have done for plInBuildTree). Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail. ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
