On 2014-11-07 15:23-0500 Hazen Babcock wrote: > On 11/07/2014 01:00 PM, Alan W. Irwin wrote: >> Hi Hazen: >> >> Arguing by analogy with the similar pkg-config case, I don't think >> removing INCLUDEPATH is the correct thing to do in plplotqt.pro (where >> that file is used by qmake to generated compile and link flags for >> users similarly to the way that pkg-config does the same thing from >> information collected in *.pc files). So I have handled INCLUDEPATH a >> different way in plplotqt.pro(.in). For further discussion see the >> commit message for 03ad89d. This is my first experience with *.pro >> files so if my analysis of their documentation is incorrect, feel free >> to make further changes. But regardless of that, please follow up on >> the ToDo item at the end of the commit message (i.e., figure out where >> the best place would be to install plplotqt.pro in the install tree, >> and then implement that installation). > > I'm pretty sure that we don't need plplotqt.pro at all. I thought it was used > during the plplot build process by qmake in order to compile > libsmokeplplotqt, however as you point out that is not what it's for. Since > it exists solely for that purpose I don't think it has any utility. Other > projects that might use our smoke bindings don't need to know how to compile > this library since it should already be compiled.
Hi Hazen: I think we are largely in agreement here. After I wrote the above I realized you previously were using that file to build the smoke bindings using qmake, but, of course, that is no longer necessary; PLplot uses CMake to build those bindings with no reference to qmake so I absolutely agree there is no present purpose for this file. So we could just eliminate it altogether. However, I lean _slightly_ toward keeping it for now as a first example of a configured *.pro file which we would later change into something more useful as we learned more about qmake. For example, our traditional build system for the installed PLplot examples currently uses Make and pkg-config exclusively. Take a look at examples/c++/Makefile.examples.in to see how complicated the Qt parts of the build currently are when constraining ourselves to just using pkg-config to obtain the necessary compile and link flags. I think it is likely if we used qmake for the Qt-related parts of the build it would simplify that file, and also provide an improved build example for users building a PLplot/Qt application for themselves who are not interested in using CMake, but who are likely experienced with qmake. The current plplotqt.pro.in file will likely need some changes to be a help to that traditional build system _and_ PLplot/Qt users in general. So I mainly view it now as an uninstalled placeholder serving as a reminder of what might be possible with qmake. But such a placeholder is not really that necessary; we can rely instead on collective memory to remind us of the qmake possibility with our traditional build system). So I don't feel strongly one way or the other about it, and I feel you have a lot more Qt expertise than I do. So it appears the choices are (1) delete, (2) status quo, or (3) modify plplotqt.pro.in to be used in examples/c++/Makefile.examples.in. I will be happy to go along with whatever choice you feel is appropriate at this stage. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
