Hi Phil:

Thanks for your documentation (commit id 2d04be) of the plmap*
functionality you implemented earlier this year. In general, the
contents of your documentation additions are fine, but there two
issues which I noticed.

1. "make info" had a showstopping issue.  Further investigation with
the "make validate" command reveals the following issue:

/usr/bin/onsgmls:/home/software/plplot/HEAD/plplot.git/doc/docbook/src/api.xml:8816:13:E:
ID "plmapstring" already defined
/usr/bin/onsgmls:/home/software/plplot/HEAD/plplot.git/doc/docbook/src/api.xml:8630:13:
ID "plmapstring" first defined here
make[3]: *** [doc/docbook/src/CMakeFiles/validate] Error 1
make[2]: *** [doc/docbook/src/CMakeFiles/validate.dir/all] Error 2
make[1]: *** [doc/docbook/src/CMakeFiles/validate.dir/rule] Error 2
make: *** [validate] Error 2

The issue (which I fixed in commit id 2ce9ff9) was that "plmapstring"
should be replaced by "plmapfill" on line 8630.  After that simple
fix, "make validate" worked, and the "man", "info", "html", and
"print" targets built without issues.

2. The order of plline and plfill should be swapped both in
doc/docbook/src/plplotdoc.xml.in and doc/docbook/src/api.xml to
be consistent with the alphabetic ordering of the other entities
and sect1 tags in those files.  I leave this to you to fix.

Issue 1 brings up the previous issue you discussed that "make
validate" was not working for you on Cygwin.  Please follow up on my
reply <https://sourceforge.net/p/plplot/mailman/message/33046456/>
where I suggested a simple fix for that issue.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to