On Thu, Mar 19, 2015 at 09:09:27AM -0700, Alan Irwin wrote: > On 2015-03-19 09:08-0000 Andrew Ross wrote: > > > > >>The attached patch fixes the memory leak for me. Pressing the close button > >>should now behave the same as pressing 'Q', i.e. it will abort the > >>program and clean up correctly. It looks like this was changed at some > >>stage in the past, but I don't know why. I guess this would allow a > >>programme to continue, and to potentially reopen a new xwin window. If we > >>want to retain this functionality it will require a bit more thinking > >>about. > > > >Thinking some more about this, I seem to recall the change was made > >because of interactive bindings. For example, if you are using octave and > >pressed the close button then the call to plabort would kill your entire > >octave session which is clearly not desirable. We definitely don't want to > >apply my patch as is. I need to work through all the tidy up code in > >xwin.c to check exactly the path that is being followed. The current code > >is doing the right thing in terms of closing the window and ignoring all > >further commands to the plplot stream, we just need to ensure that the > >tidy function is called at the end. A clean way of doing this would be to > >have multiple levels of stream_closed. 0 = open, 1 = closed, but still > >need to call tidy, 2 = closed and tidy already called. > > > >Only the xwin and cairo drivers set this flag, but it is checked in the > >core plplot code. I can simply implement this change Alan, but your call > >whether you want to commit it at this late stage. It should be trivial. > > With regard to that fix you might also find -dev tk affected since > that device driver uses parts of -dev xwin if I recall correctly. > > But in any case, let's stick with the idea of regression fixes only > since we are so near to release. But by all means please implement it > on a topic branch ready to be pushed post release.
It's possible -dev tk is also affected. Anyway, I'll hold the fix until post-release. Andrew ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
