> > On 05/11/2015 06:05 PM, Alan W. Irwin wrote: >> >> Hi Hazen: >> >> I am glad to hear you have created a topic branch that catches >> floating point exceptions. However, I am not keen on pulling a PLplot >> topic branch from github for the reasons discussed in >> README.developers. So could you either share your topic branch using >> "git format-patch" or else just push it to our official repo yourself? >> The former is preferred if the work is incomplete (i.e., does not >> include a cmake option to control when the PLPLOT_ENABLE_FLOAT_EXCEPT >> macro is #defined). Furthermore, if the work is incomplete, I can >> finish the cmake aspects of it as promised above and amend your commit >> accordingly. >> >> Once we have implemented an option to check for floating-point >> exceptions, then that means any of us should be able to confirm the >> ones you have found and find others in the future due to the continued >> evolution of our examples. And, of course, this option should allow >> us to fix those floating-point exceptions as time permits. > > Hi Alan, > > Sorry, that branch was not meant for incorporation into PLplot which is > why I did not follow accepted protocols. I thought it might make it > easier for others to see the floating point exception problem for these > 3 examples. > > I think we can enable floating point exception trapping more easily > using the -ffpe-trap option provided by gfortran. This won't require us > to mark up all of our C examples, though we might instead need to check > that the fortran compiler is gfortran? > > https://gcc.gnu.org/onlinedocs/gfortran/Debugging-Options.html > > -ffpe-trap=invalid,zero,overflow,underflow > > Compiling PLplot with this fortran flag (CMAKE_Fortran_FLAGS) "worked" > for me in that it core dumps on the fortran equivalents of the C > examples I mentioned above. I've attached my CMakeCache.txt file. > > -Hazen
Hm.. example 21 also generates an FPE, but at least in this case it looks like it is coming from the qhull library. And example 29 also generates an FPE, but only the Fortran version not the C version. So, maybe it would be better in the end to add this check to all of the C examples as well? -Hazen ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
